Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection invitation handling improvements #48

Closed
6 tasks
andrewwhitehead opened this issue Jul 9, 2019 · 4 comments
Closed
6 tasks

Connection invitation handling improvements #48

andrewwhitehead opened this issue Jul 9, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@andrewwhitehead
Copy link
Contributor

Some updates to improve the granularity of the 'auto-accept' feature for invitations and reduce the number of configuration options.

  • Remove the --accept-invites and --accept-requests command line parameters

  • Add an auto_accept property to connection records. When the flag is set on a given connection record and corresponding connection request is later received, automatically send a connection response.

  • Add an auto_accept parameter to the connections_create_invitation route. This simply sets the flag on the new connection record.

  • Add an auto_accept parameter to the connections_receive_invitation route. If the parameter is set, automatically send a new connection request based on the invitation.

  • Update demos (including IIWBook and email verification) to pass these parameters instead of setting the command line flags.

  • Update documentation if necessary.

@swcurran @nrempel Does that sound reasonable?

@swcurran
Copy link
Contributor

swcurran commented Jul 9, 2019

@andrewwhitehead - what is the planned timing on this? I have this documented in the OpenAPI demo that I'm planning to use on Wednesday. Are you talking before or after?

Documentation is here: https://github.com/hyperledger/aries-cloudagent-python/blob/master/demo/AriesOpenAPIDemo.md#running-the-demo-steps

Main thing to look at is the invocation.

@andrewwhitehead andrewwhitehead added the enhancement New feature or request label Jul 9, 2019
@andrewwhitehead
Copy link
Contributor Author

@swcurran I'm not planning to implement this right away, nothing is currently depending on it.

@swcurran
Copy link
Contributor

swcurran commented Jul 9, 2019 via email

@andrewwhitehead
Copy link
Contributor Author

Resolved via #82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants