Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET /credentials does not return credential_id #174

Closed
SmithSamuelM opened this issue Sep 9, 2019 · 0 comments
Closed

GET /credentials does not return credential_id #174

SmithSamuelM opened this issue Sep 9, 2019 · 0 comments
Assignees

Comments

@SmithSamuelM
Copy link

This issue is a result of figuring out the issue #163

The problem is that GET /credentials does not return the credential_id needed to use GET /credentials/{id}

The only place to find credential_id is in the associated exchange record but finding the appropriate record may be problematic. But once found the record has three credential ID related fields. These are

cred_def_id
credential_exchange_id
credential_id

It would be great to document in the Swagger interface or other docs that there are indeed Three different ids that the ACA-PY uses and it would simplify use of the API if GET /credentials returned the right one needed for the GET /credentials/{id}

andrewwhitehead added a commit that referenced this issue Sep 10, 2019
Fixes #174 Adds document about credential_id is same as referent
rosenbrockc pushed a commit to rosenbrockc/aries-cloudagent-python that referenced this issue Sep 11, 2019
…same as referent

Signed-off-by: Stephen Curran <[email protected]>
Signed-off-by: Conrad Rosenbrock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants