Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acme Controller Workshop: Unclear instructions for issuing work credential #1477

Closed
eliasschoof opened this issue Nov 4, 2021 · 2 comments · Fixed by #1484
Closed

Acme Controller Workshop: Unclear instructions for issuing work credential #1477

eliasschoof opened this issue Nov 4, 2021 · 2 comments · Fixed by #1484

Comments

@eliasschoof
Copy link
Contributor

I am working through the Acme Controller Workshop. First: A big thanks to everyone who contributed! I find it very easy to follow and I am learning a lot along the way.

One step left me scratching my head, though. In Section "Issuing Alice a Work Credential", what should I do with this piece of code?

        with log_timer("Publish schema and cred def duration:"):
            # define schema
            version = format(
                "%d.%d.%d"
                % (
                    random.randint(1, 101),
                    random.randint(1, 101),
                    random.randint(1, 101),
                )
            )
            # (schema_id, cred_def_id) = await agent.register_schema_and_creddef(
                "employee id schema",
                version,
                ["employee_id", "name", "date", "position"],
                support_revocation=False,
                revocation_registry_size=TAILS_FILE_COUNT,
            )

Should I copy-paste this? Where?

@ianco
Copy link
Contributor

ianco commented Nov 4, 2021

Hi @estrehle I think that is old code, I'll remove it from the instructions.

@eliasschoof
Copy link
Contributor Author

@ianco Thanks for getting back! I played around a bit and found out that I actually need to copy-paste this code right after the previous code bit. Otherwise we're missing a definition for schema_id and cred_def_id which are used later. I'll suggest a fix and create a PR.

eliasschoof added a commit to eliasschoof/aries-cloudagent-python that referenced this issue Nov 9, 2021
The instructions at this place were unclear, see openwallet-foundation#1477. This is a proposed fix that makes it clear that the "lost" code should be copy-pasted.
eliasschoof added a commit to eliasschoof/aries-cloudagent-python that referenced this issue Nov 9, 2021
The instructions at this place were unclear, see openwallet-foundation#1477. This is a proposed fix that makes it clear where the code snippet should be inserted.

Signed-off-by: Elias Strehle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment