Skip to content

Commit

Permalink
chore: update deprecation notice for did:sov msg prefix
Browse files Browse the repository at this point in the history
Signed-off-by: Daniel Bluhm <[email protected]>
  • Loading branch information
dbluhm committed Mar 22, 2024
1 parent c5c26af commit ff88d30
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 9 deletions.
8 changes: 5 additions & 3 deletions aries_cloudagent/config/logging.py
Original file line number Diff line number Diff line change
Expand Up @@ -342,9 +342,11 @@ def print_notices(cls, settings: Settings):
)
banner.hr()
banner.print(
"Using `did:sov:BzCbsNYhMrjHiqZDTUASHg;spec` in protocols is deprecated "
"and support will be removed in a future version; use "
"https://didcomm.org/ instead."
"Receiving a core DIDComm protocol with the "
"`did:sov:BzCbsNYhMrjHiqZDTUASHg;spec` prefix is deprecated. All parties "
"sending this prefix should be notified that support for receiving such "
"messages will be removed in an upcoming ACA-Py release. "
"Use https://didcomm.org/ instead."
)
print()

Expand Down
14 changes: 8 additions & 6 deletions aries_cloudagent/core/dispatcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -289,15 +289,17 @@ async def make_message(

if message_type.startswith("did:sov"):
warnings.warn(
"Using `did:sov:BzCbsNYhMrjHiqZDTUASHg;spec` in protocols is deprecated "
"and support will be removed in a future version; use "
"https://didcomm.org/ instead.",
"Received a core DIDComm protocol with the deprecated "
"`did:sov:BzCbsNYhMrjHiqZDTUASHg;spec` prefix. The sending party should "
"be notified that support for receiving such messages will be removed in "
"an upcoming ACA-Py release. Use https://didcomm.org/ instead.",
DeprecationWarning,
)
self.logger.warning(
"Using `did:sov:BzCbsNYhMrjHiqZDTUASHg;spec` in protocols is deprecated "
"and support will be removed in a future version; use "
"https://didcomm.org/ instead.",
"Received a core DIDComm protocol with the deprecated "
"`did:sov:BzCbsNYhMrjHiqZDTUASHg;spec` prefix. The sending party should "
"be notified that support for receiving such messages will be removed in "
"an upcoming ACA-Py release. Use https://didcomm.org/ instead.",
)

message_type_rec_version = get_version_from_message_type(message_type)
Expand Down

0 comments on commit ff88d30

Please sign in to comment.