Merge pull request #1665 from hyperledger/fix/always-notify-if-notifi…

…cation-record

fix: always notify if revocation notification record exists

aries_cloudagent/protocols/revocation_notification/v1_0/routes.py

@@ -32,7 +32,6 @@ async def on_revocation_published(profile: Profile, event: Event):
     """Handle issuer revoke event."""
     LOGGER.debug("Sending notification of revocation to recipient: %s", event.payload)
 
-    should_notify = profile.settings.get("revocation.notify", False)
     responder = profile.inject(BaseResponder)
     crids = event.payload.get("crids") or []
 
@@ -46,10 +45,9 @@ async def on_revocation_published(profile: Profile, event: Event):
 
             for record in records:
                 await record.delete_record(session)
-                if should_notify:
-                    await responder.send(
-                        record.to_message(), connection_id=record.connection_id
-                    )
+                await responder.send(
+                    record.to_message(), connection_id=record.connection_id
+                )
 
     except StorageNotFoundError:
         LOGGER.info(

aries_cloudagent/protocols/revocation_notification/v1_0/tests/test_routes.py

@@ -50,7 +50,6 @@ async def test_on_revocation_published(profile: Profile, responder: MockResponde
     event = Event(topic, {"rev_reg_id": "mock", "crids": ["mock"]})
 
     assert isinstance(profile.settings, Settings)
-    profile.settings["revocation.notify"] = True
 
     with mock.patch.object(test_module, "RevNotificationRecord", MockRec):
         await test_module.on_revocation_published(profile, event)
@@ -60,32 +59,6 @@ async def test_on_revocation_published(profile: Profile, responder: MockResponde
     assert responder.messages
 
 
-@pytest.mark.asyncio
-async def test_on_revocation_published_no_notify(
-    profile: Profile, responder: MockResponder
-):
-    """Test revocation published event handler."""
-    mock_rec = mock.MagicMock()
-    mock_rec.cred_rev_id = "mock"
-    mock_rec.delete_record = mock.CoroutineMock()
-
-    MockRec = mock.MagicMock()
-    MockRec.query_by_rev_reg_id = mock.CoroutineMock(return_value=[mock_rec])
-
-    topic = f"{REVOCATION_EVENT_PREFIX}{REVOCATION_PUBLISHED_EVENT}::mock"
-    event = Event(topic, {"rev_reg_id": "mock", "crids": ["mock"]})
-
-    assert isinstance(profile.settings, Settings)
-    profile.settings["revocation.notify"] = False
-
-    with mock.patch.object(test_module, "RevNotificationRecord", MockRec):
-        await test_module.on_revocation_published(profile, event)
-
-    MockRec.query_by_rev_reg_id.assert_called_once()
-    mock_rec.delete_record.assert_called_once()
-    assert not responder.messages
-
-
 @pytest.mark.asyncio
 async def test_on_revocation_published_x_not_found(
     profile: Profile, responder: MockResponder