fix: unawaited coroutines in test conductor

Signed-off-by: Daniel Bluhm <[email protected]>
openwallet-foundation · Oct 27, 2023 · 89e87c1 · 89e87c1
1 parent 5b64fc1
commit 89e87c1
Showing 1 changed file with 14 additions and 3 deletions.
diff --git a/aries_cloudagent/core/tests/test_conductor.py b/aries_cloudagent/core/tests/test_conductor.py
@@ -708,7 +708,10 @@ async def test_handle_nots(self):
             ) as mock_conn_mgr, mock.patch.object(
                 conductor.dispatcher, "run_task", mock.MagicMock()
             ) as mock_run_task:
-                mock_conn_mgr.return_value.get_connection_targets = mock.CoroutineMock()
+                # Normally this should be a coroutine mock; however, the coroutine
+                # is awaited by dispatcher.run_task, which is mocked here. MagicMock
+                # to prevent unawaited coroutine warning.
+                mock_conn_mgr.return_value.get_connection_targets = mock.MagicMock()
                 mock_run_task.side_effect = test_module.ConnectionManagerError()
                 await conductor.queue_outbound(conductor.root_profile, message)
                 mock_outbound_mgr.return_value.enqueue_message.assert_not_called()
@@ -749,7 +752,12 @@ async def test_handle_not_returned_ledger_x(self):
         with mock.patch.object(
             conductor.dispatcher, "run_task", mock.MagicMock()
         ) as mock_dispatch_run, mock.patch.object(
-            conductor, "queue_outbound", mock.CoroutineMock()
+            # Normally this should be a coroutine mock; however, the coroutine
+            # is awaited by dispatcher.run_task, which is mocked here. MagicMock
+            # to prevent unawaited coroutine warning.
+            conductor,
+            "queue_outbound",
+            mock.MagicMock(),
         ) as mock_queue, mock.patch.object(
             conductor.admin_server, "notify_fatal_error", mock.MagicMock()
         ) as mock_notify:
@@ -789,7 +797,10 @@ async def test_queue_outbound_ledger_x(self):
         ) as mock_dispatch_run, mock.patch.object(
             conductor.admin_server, "notify_fatal_error", mock.MagicMock()
         ) as mock_notify:
-            conn_mgr.return_value.get_connection_targets = mock.CoroutineMock()
+            # Normally this should be a coroutine mock; however, the coroutine
+            # is awaited by dispatcher.run_task, which is mocked here. MagicMock
+            # to prevent unawaited coroutine warning.
+            conn_mgr.return_value.get_connection_targets = mock.MagicMock()
             mock_dispatch_run.side_effect = test_module.LedgerConfigError(
                 "No such ledger"
             )