style: keep param naming consistent

Signed-off-by: Daniel Bluhm <[email protected]>
openwallet-foundation · Aug 2, 2023 · 27b5213 · 27b5213
1 parent 43ada23
commit 27b5213
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/aries_cloudagent/protocols/didexchange/v1_0/manager.py b/aries_cloudagent/protocols/didexchange/v1_0/manager.py
@@ -231,7 +231,7 @@ async def create_request_implicit(
             mediation_id=mediation_id,
             goal_code=goal_code,
             goal=goal,
-            public_did=bool(my_public_info),
+            use_public_did=bool(my_public_info),
         )
         conn_rec.request_id = request._id
         conn_rec.state = ConnRecord.State.REQUEST.rfc23
@@ -251,7 +251,7 @@ async def create_request(
         mediation_id: Optional[str] = None,
         goal_code: Optional[str] = None,
         goal: Optional[str] = None,
-        public_did: bool = False,
+        use_public_did: bool = False,
     ) -> DIDXRequest:
         """
         Create a new connection request for a previously-received invitation.
@@ -264,6 +264,8 @@ async def create_request(
                 service endpoint
             goal_code: Optional self-attested code for sharing intent of connection
             goal: Optional self-attested string for sharing intent of connection
+            use_public_did: Flag whether to use public DID and omit DID Doc
+                attachment on request
         Returns:
             A new `DIDXRequest` message to send to the other agent
 
@@ -315,7 +317,7 @@ async def create_request(
                 my_endpoints.append(default_endpoint)
             my_endpoints.extend(self.profile.settings.get("additional_endpoints", []))
 
-        if public_did:
+        if use_public_did:
             # Omit DID Doc attachment if we're using a public DID
             did_doc = None
             attach = None

diff --git a/aries_cloudagent/protocols/didexchange/v1_0/tests/test_manager.py b/aries_cloudagent/protocols/didexchange/v1_0/tests/test_manager.py
@@ -490,7 +490,7 @@ async def test_create_request_public_did(self):
             save=async_mock.CoroutineMock(),
         )
 
-        request = await self.manager.create_request(mock_conn_rec, public_did=True)
+        request = await self.manager.create_request(mock_conn_rec, use_public_did=True)
         assert request.did_doc_attach is None
 
     async def test_receive_request_explicit_public_did(self):