Merge pull request #1378 from Fethbita/main

Allow underscore in endpoints
openwallet-foundation · Aug 31, 2021 · 102d9f1 · 102d9f1
2 parents c413fab + f4981b9
commit 102d9f1
Show file tree

Hide file tree

Showing 3 changed files with 2,427 additions and 466 deletions.
diff --git a/aries_cloudagent/messaging/tests/test_valid.py b/aries_cloudagent/messaging/tests/test_valid.py
@@ -463,7 +463,6 @@ def test_endpoint(self):
             "",
             "/path/only",
             "https://1.2.3.4?query=true&url=false",
-            "http://no_tld/bad",
             "no-proto:8080/my/path",
             "smtp:8080/my/path#fragment",
         ]

diff --git a/aries_cloudagent/messaging/valid.py b/aries_cloudagent/messaging/valid.py
@@ -638,7 +638,7 @@ class Endpoint(Regexp):  # using Regexp brings in nice visual validator cue
     EXAMPLE = "https://myhost:8021"
     PATTERN = (
         r"^[A-Za-z0-9\.\-\+]+:"  # scheme
-        r"//([A-Za-z0-9][.A-Za-z0-9-]+[A-Za-z0-9])+"  # host
+        r"//([A-Za-z0-9][.A-Za-z0-9-_]+[A-Za-z0-9])+"  # host
         r"(:[1-9][0-9]*)?"  # port
         r"(/[^?&#]+)?$"  # path
     )