Backport PR 3391

Signed-off-by: jamshale <[email protected]>
openwallet-foundation · Dec 10, 2024 · 012b90c · 012b90c
1 parent c901828
commit 012b90c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 16 deletions.
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -51,12 +51,6 @@ jobs:
         uses: actions/checkout@v3
         with:
           ref: ${{ inputs.ref || '' }}
-
-      - name: Gather image info
-        id: info
-        run: |
-          echo "repo-owner=${GITHUB_REPOSITORY_OWNER,,}" >> $GITHUB_OUTPUT
-
       - name: Cache Docker layers
         uses: actions/cache@v3
         with:
@@ -72,15 +66,15 @@ jobs:
         uses: docker/login-action@v2
         with:
           registry: ghcr.io
-          username: ${{ github.repository_owner }}
-          password: ${{ secrets.GITHUB_TOKEN }}
+          username: hyperledger
+          password: ${{ secrets.HYPERLEDGER_GHCR_PAT }}
 
       - name: Setup Image Metadata
         id: meta
         uses: docker/metadata-action@v4
         with:
           images: |
-            ghcr.io/${{ steps.info.outputs.repo-owner }}/aries-cloudagent-python
+            ghcr.io/hyperledger/aries-cloudagent-python
           tags: |
             type=raw,value=py${{ matrix.python-version }}-${{ inputs.tag || github.event.release.tag_name }}
 

diff --git a/aries_cloudagent/askar/profile.py b/aries_cloudagent/askar/profile.py
@@ -5,7 +5,6 @@
 import time
 
 # import traceback
-
 from typing import Any, Mapping
 from weakref import ref
 
@@ -26,8 +25,7 @@
 from ..utils.multi_ledger import get_write_ledger_config_for_profile
 from ..wallet.base import BaseWallet
 from ..wallet.crypto import validate_seed
-
-from .store import AskarStoreConfig, AskarOpenStore
+from .store import AskarOpenStore, AskarStoreConfig
 
 LOGGER = logging.getLogger(__name__)
 
@@ -118,7 +116,7 @@ def bind_providers(self):
             VCHolder,
             ClassProvider(
                 "aries_cloudagent.storage.vc_holder.askar.AskarVCHolder",
-                ref(self),
+                ClassProvider.Inject(Profile),
             ),
         )
         if (

diff --git a/aries_cloudagent/storage/vc_holder/tests/test_askar_vc_holder.py b/aries_cloudagent/storage/vc_holder/tests/test_askar_vc_holder.py
@@ -1,12 +1,10 @@
 import pytest
 
-
 from ....askar.profile import AskarProfileManager
 from ....config.injection_context import InjectionContext
-
+from ..askar import AskarVCHolder
 from ..base import VCHolder
 from ..vc_record import VCRecord
-
 from . import test_in_memory_vc_holder as in_memory
 
 
@@ -22,6 +20,7 @@ async def make_profile():
             "key_derivation_method": "RAW",  # much faster than using argon-hashed keys
         },
     )
+    profile.context.injector.bind_instance(VCHolder, AskarVCHolder(profile))
     return profile