Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OWF migration prep #690

Merged
merged 11 commits into from
Dec 17, 2024
Merged

OWF migration prep #690

merged 11 commits into from
Dec 17, 2024

Conversation

esune
Copy link
Member

@esune esune commented Dec 4, 2024

This PR includes changes related to the future migration of the project to OWF:

  • Removes custom GHA responsible for pushing deployments to BCGov-owned environments
  • Renames the project to acapy-vc-authn-oidc
  • Renames components to drop the aries naming where possible
  • Provides a new OWF-like skin for webpages

Note:

  • The chart name and variables were left as vc-authn as it would cause a lot of overhead to replace everything, for little to no value (in my opinion)
  • Existing documentation retains the VC-AuthN nomenclature if it does not cause issues with understanding the content

Still in the works:

  • QR Code page re-skinning
  • Proof-request configuration explorer re-skinning

Resolves #684

esune added 6 commits December 4, 2024 10:17
Signed-off-by: Emiliano Suñé <[email protected]>
Signed-off-by: Emiliano Suñé <[email protected]>
Signed-off-by: Emiliano Suñé <[email protected]>
Signed-off-by: Emiliano Suñé <[email protected]>
Signed-off-by: Emiliano Suñé <[email protected]>
@esune esune requested a review from loneil December 4, 2024 20:54
@esune
Copy link
Member Author

esune commented Dec 4, 2024

A couple more things that will require attention, either in this PR or shortly after:

  • We need to be able to dynamically mount a custom QR code page and related assets. Currently the Helm chart does not support this, and the code only supports using custom HTML (not adding/replacing assets).
  • We need to store a backup of the existing pages to be reused for BCGov deployments.
  • Wording in the QR code page revolves around the use of BC Wallet: how can we update this to be less specific?

@loneil
Copy link
Contributor

loneil commented Dec 5, 2024

Additional consideration for this repo maybe along with the 3 above. The Readme has curl commands to set up proof specific to the BC Wallet person cred check.

Copy link
Contributor

@loneil loneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this out locally against an existing build and with a from-scratch one, things still working as expected for the app and demo.

If we're taking out the push-to-main action build would we need releases to go to our dev env or can we still have dev running of a main build?

Not too important since it's just the demo but the logo colors look like:
image

@esune
Copy link
Member Author

esune commented Dec 5, 2024

I tested this out locally against an existing build and with a from-scratch one, things still working as expected for the app and demo.

If we're taking out the push-to-main action build would we need releases to go to our dev env or can we still have dev running of a main build?

Not too important since it's just the demo but the logo colors look like: image

For the update strategy for our dev: I am not sure, we will need to figure out what the best strategy is. We could set-up either way, just not from the repo directly I think.

For the UI I will try and tweak colors, I just tried to make it "acceptable" as a first pass 😄

Signed-off-by: Emiliano Suñé <[email protected]>
@esune esune requested a review from loneil December 11, 2024 18:25
@esune esune marked this pull request as ready for review December 11, 2024 18:25
@esune
Copy link
Member Author

esune commented Dec 11, 2024

I pushed a couple more tweaks, including bumping the chart version to a different minor to more clearly indicate the shift.
UI tweaks were basic and targeting a general rebranding, more tweaks/work can be done once the project has moved.

Signed-off-by: Emiliano Suñé <[email protected]>
Copy link
Contributor

@loneil loneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor (and in the demo) but the files chesService and cdogsService can be removed as they reference BCGov common services from the scaffold app.
Then any refernce to serviceClient config is unneeded too.

demo/vue/app/config/test.json Outdated Show resolved Hide resolved
Signed-off-by: Emiliano Suñé <[email protected]>
@esune esune requested a review from loneil December 11, 2024 18:59
README.md Outdated Show resolved Hide resolved
Signed-off-by: Emiliano Suñé <[email protected]>
@esune
Copy link
Member Author

esune commented Dec 13, 2024

Thanks for the review @loneil!

@WadeBarnes I think we could plan the next steps of the move now.

@WadeBarnes
Copy link
Contributor

Coordinating the move.

@WadeBarnes
Copy link
Contributor

I'll merge this PR right before the move.

@WadeBarnes WadeBarnes merged commit 9d12f5d into main Dec 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OWF Migration
3 participants