-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OWF migration prep #690
OWF migration prep #690
Conversation
Signed-off-by: Emiliano Suñé <[email protected]>
Signed-off-by: Emiliano Suñé <[email protected]>
Signed-off-by: Emiliano Suñé <[email protected]>
Signed-off-by: Emiliano Suñé <[email protected]>
Signed-off-by: Emiliano Suñé <[email protected]>
Signed-off-by: Emiliano Suñé <[email protected]>
A couple more things that will require attention, either in this PR or shortly after:
|
Additional consideration for this repo maybe along with the 3 above. The Readme has curl commands to set up proof specific to the BC Wallet person cred check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this out locally against an existing build and with a from-scratch one, things still working as expected for the app and demo.
If we're taking out the push-to-main action build would we need releases to go to our dev
env or can we still have dev running of a main
build?
Not too important since it's just the demo but the logo colors look like:
Signed-off-by: Emiliano Suñé <[email protected]>
Signed-off-by: Emiliano Suñé <[email protected]>
I pushed a couple more tweaks, including bumping the chart version to a different minor to more clearly indicate the shift. |
Signed-off-by: Emiliano Suñé <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor (and in the demo) but the files chesService
and cdogsService
can be removed as they reference BCGov common services from the scaffold app.
Then any refernce to serviceClient
config is unneeded too.
Signed-off-by: Emiliano Suñé <[email protected]>
Signed-off-by: Emiliano Suñé <[email protected]>
Thanks for the review @loneil! @WadeBarnes I think we could plan the next steps of the move now. |
Coordinating the move. |
I'll merge this PR right before the move. |
This PR includes changes related to the future migration of the project to OWF:
acapy-vc-authn-oidc
aries
naming where possibleNote:
vc-authn
as it would cause a lot of overhead to replace everything, for little to no value (in my opinion)Still in the works:QR Code page re-skinningProof-request configuration explorer re-skinningResolves #684