Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back handshake protocols #650

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Add back handshake protocols #650

merged 1 commit into from
Oct 3, 2024

Conversation

loneil
Copy link
Contributor

@loneil loneil commented Oct 3, 2024

Add back in the handshake protocols field in the model for OOB invitations. See details here #583

BC Wallet has released a while back with the Credo version that handles this now.

We provide a blank array in default setup for VCAuth at this time:

image

@loneil loneil self-assigned this Oct 3, 2024
@loneil loneil requested review from esune and Gavinok October 3, 2024 04:38
@loneil loneil removed their assignment Oct 3, 2024
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@loneil you were able to test this so we can merge, right?

Signed-off-by: Lucas ONeil <[email protected]>
@loneil loneil force-pushed the feature/addBackHandshakes branch from 7e3eff3 to b13bc1d Compare October 3, 2024 21:00
@loneil
Copy link
Contributor Author

loneil commented Oct 3, 2024

LGTM 👍🏻

@loneil you were able to test this so we can merge, right?

Yeah can go ahead, tested out on iPad release version and Android beta

@esune esune merged commit eebbbcc into main Oct 3, 2024
6 checks passed
@esune esune deleted the feature/addBackHandshakes branch October 3, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants