Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add handshake_protocols to oob invitation #577

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

genaris
Copy link
Contributor

@genaris genaris commented Jul 8, 2024

I noticed that handshake_protocols field is gone when ACA-Py client parses the response. Usually it is not used in BCGov main use-case but I'm trying to use it in a case where I want to use a public DID and re-use any connection with the service.

@loneil loneil self-requested a review July 8, 2024 22:47
Copy link
Contributor

@loneil loneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes in our current use case we did not need handshake_protocols, I tested it with and without an empty array with this change and still working as expected in our case.

Thanks for the fix!

@loneil loneil merged commit 77ff110 into openwallet-foundation:main Jul 9, 2024
3 checks passed
@genaris genaris deleted the fix/oob-model branch July 9, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants