Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get wallet did only when not using USE_OOB_PRESENT_PROOF #576

Merged
merged 3 commits into from
Jul 9, 2024
Merged

fix: get wallet did only when not using USE_OOB_PRESENT_PROOF #576

merged 3 commits into from
Jul 9, 2024

Conversation

genaris
Copy link
Contributor

@genaris genaris commented Jul 8, 2024

Some minor optimizations for the newly introduced USE_OOB_PRESENT_PROOF mode:

  • Do not ask ACA-Py for wallet DID in such case
  • Don't create any PPV1 attachment at this step, since it will be created by ACA-Py
  • Also don't call ACA-Py client constructor twice

@loneil loneil self-requested a review July 8, 2024 22:47
loneil
loneil approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@loneil loneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches, works for me. Thanks

@loneil loneil merged commit 3b64c49 into openwallet-foundation:main Jul 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loneil loneil loneil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@genaris @loneil