Fix Out-Of-Band invitation option for QR codes #556
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #545
Instead of building up a OOB invitation with code in VCAuth controller (this was not working, error boiled down to recipient keys not being added), call ACA-Py to use
out-of-band/create-invitation
with the resultant presentation exchange.Use the invitation returned from that as the QR code linked payload.
Note this should only be used in QR code mode at the moment (which is what we configure in all envs for
USE_OOB_PRESENT_PROOF
) as doing it as a deep link runs into the 'too many characters' issue. A OOB is bigger than a Connections type so there's not really room for the actual proof unless it's narrowed to something as minimal as it gets.This will be solved by #504 anyways, so we won't be using the current deep link paradigm much longer anyways.
Sample payload