-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backwards compatibility setting for token claims #349
Add backwards compatibility setting for token claims #349
Conversation
ae1749b
to
ee42694
Compare
Signed-off-by: jamshale <[email protected]>
Signed-off-by: jamshale <[email protected]>
Signed-off-by: jamshale <[email protected]>
cb80345
to
e61ebac
Compare
@jamshale before merging, just confirming you tested having an "older" release with stored configs and upgrading and it works as expected? |
@esune I haven't ran any testing where I started a v1.0 and upgraded to v2.0. I can do that. |
Sorry for the confusion, as discussed in person what I meant was 2.0 before this change and after this change. No need to test the whole upgrade from 1.0. |
@esune Ok I tested this now and it works as expected. |
Add the environment variable and then add the attributes a separate key/value pairs to the claim object outside of the
vc_presented_attributes
object.Set the ver_config with optional include_v1_attributes field to default False. Then when getting the claims it decides to add the attributes individually based of this ver_config setting.
This is the claim object pulled from logs when running demo.
Resolves #347