Clean up default error message handling

Signed-off-by: jamshale <[email protected]>

oidc-controller/api/core/http_exception_util.py

@@ -5,8 +5,11 @@
 
 logger = structlog.getLogger(__name__)
 
+CONFLICT_DEFAULT_MSG = "The requested resource already exists"
+NOT_FOUND_DEFAULT_MSG = "The requested resource wasn't found"
+UNKNOWN_DEFAULT_MSG = "The server was unable to process the request"
 
-def raise_appropriate_http_exception(err: WriteError, exists_msg: str = None):
+def raise_appropriate_http_exception(err: WriteError, exists_msg: str = CONFLICT_DEFAULT_MSG):
     if err.code == 11000:
         raise HTTPException(
             status_code=http_status.HTTP_409_CONFLICT,
@@ -16,14 +19,11 @@ def raise_appropriate_http_exception(err: WriteError, exists_msg: str = None):
         logger.error("Unknown error", err=err)
         raise HTTPException(
             status_code=http_status.HTTP_500_INTERNAL_SERVER_ERROR,
-            detail="The server was unable to process the request",
+            detail=UNKNOWN_DEFAULT_MSG,
         )
 
 
-def check_and_raise_not_found_http_exception(resp, detail: str = None):
-    if detail is None:
-        detail = "The requested resource wasn't found"
-
+def check_and_raise_not_found_http_exception(resp, detail: str = NOT_FOUND_DEFAULT_MSG):
     if resp is None:
         raise HTTPException(
             status_code=http_status.HTTP_404_NOT_FOUND,

oidc-controller/api/verificationConfigs/crud.py

@@ -27,7 +27,7 @@ async def create(self, ver_config: VerificationConfig) -> VerificationConfig:
             ver_confs.insert_one(jsonable_encoder(ver_config))
         except Exception as err:
             raise_appropriate_http_exception(
-                err, exists_msg="Verification configuration already exists")
+                err, exists_msg="Verifier configuration already exists")
         return ver_confs.find_one({"ver_config_id": ver_config.ver_config_id})
 
     async def get(self, ver_config_id: str) -> VerificationConfig: