-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt JSON serialization #19
Conversation
Signed-off-by: Daniel Fett <[email protected]>
884f6b3
to
e0e31de
Compare
but an update to the name in the settings.yml of dependent projects (like SD-JWT VC) will be needed, no? |
What about catching the old yaml files during parsing, converting to the correct claim names (basically issuer_key -> issuer_keys for both functions parsing yaml files) and outputting a warning that |
Co-authored-by: Giuseppe De Marco <[email protected]> Signed-off-by: Daniel Fett <[email protected]>
Signed-off-by: Daniel Fett <[email protected]>
367b02d
to
fc90af6
Compare
This implements JSON serialization as outlined in oauth-wg/oauth-selective-disclosure-jwt#403 and defined in oauth-wg/oauth-selective-disclosure-jwt#414
Noteworthy changes:
issuer_keys
argument to the SDJWTIssuer MAY be an array of keys (but a single key is still supported, so no changes in legacy usages required)cb_get_issuer_key
passed to SDJWTVerifier MAY return a JWKSetsettings_override
to override whatever is defined in thesettings.yml