Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition in class Communication in package com.adroid.identity.wallet.transfer #462

Closed
nicklaswj opened this issue Jan 30, 2024 · 2 comments
Closed

Race condition in class Communication in package com.adroid.identity.wallet.transfer #462

nicklaswj opened this issue Jan 30, 2024 · 2 comments

Comments

@nicklaswj
Copy link

Expected Behavior

The method sendResponse on class Communication with the argument closeAfterSending = true (code), should only close the connection after the deviceResponse message has been sent.

Actual Behavior

If the connection and or latency on the underlying mTransport is slow enough, the above described call will close the connection before the deviceResponse has actually been sent.

Steps to Reproduce the Problem

  1. Open either the Purse or Wallet app on a real Phone (for my setup the emulator_speed/internet_speed ratio is too small to cause the race condition).
  2. Go to a www-mdl-reader website and open a mdoc url.
  3. Press the "Send data" button in the Purse or Wallet app.
  4. The www-mdl-reader will receiver no data, since the app closed the connection before the data was sent.

Specifications

  • Platform: Android 14 Samsung Galaxy S21 5G

Fix

I'll open a PR with a fix in a minute
nicklaswj pushed a commit to nicklaswj/identity-credential that referenced this issue Jan 30, 2024
Fixes: openwallet-foundation-labs#462: In com.android.identity.wallet…
488360d 
….transfer.Communication sendResponse

If `closeAfterSending` is true, only close the connection after we know the
`deviceResponse` payload have been sent.
@nicklaswj nicklaswj mentioned this issue Jan 30, 2024
Closed
nicklaswj pushed a commit to nicklaswj/identity-credential that referenced this issue Feb 1, 2024
Fixes: openwallet-foundation-labs#462: In com.android.identity.wallet…
60f9643 
….transfer.Communication sendResponse

If `closeAfterSending` is true, only close the connection after we know the
`deviceResponse` payload have been sent.

Signed-off-by: Nicklas Warming Jacobsen <[email protected]>
nicklaswj pushed a commit to nicklaswj/identity-credential that referenced this issue Feb 1, 2024
Fixes: openwallet-foundation-labs#462: In com.android.identity.wallet…
1cb88d0 
….transfer.Communication sendResponse

If `closeAfterSending` is true, only close the connection after we know the
`deviceResponse` payload have been sent.

Signed-off-by: Nicklas Warming Jacobsen <[email protected]>
@github-actions GitHub Actions
Copy link

This issue is being closed as stale

@github-actions GitHub Actions
Copy link

Doing some cleanup/spring cleaning and closing all issues older than 90 days. Please reopen if issue is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@nicklaswj