Skip to content

Commit

Permalink
sparse: Remove wrappers for some DPDK headers.
Browse files Browse the repository at this point in the history
Since sparse v0.6.4 (which is 3 years old and happens to be the latest
official release), GCC atomic builtins are recognised by sparse
(see below first three links).

In the case of rte_atomic.h, DPDK stopped using __sync in favor of
__atomic builtin in v23.07 (see below last link).
However, no OVS developer complained about sparse build failures because
of rte_atomic.h which means that everyone uses a recent sparse (if any).

Remove wrappers around those DPDK headers.

Link: https://git.kernel.org/pub/scm/devel/sparse/sparse.git/commit/?id=cf8f104749f5
Link: https://git.kernel.org/pub/scm/devel/sparse/sparse.git/commit/?id=7cdf84691f33
Link: https://git.kernel.org/pub/scm/devel/sparse/sparse.git/commit/?id=f42e2afa9ed0
Link: https://git.dpdk.org/dpdk/commit/?id=a2f807316dae
Signed-off-by: David Marchand <[email protected]>
Acked-by: Aaron Conole <[email protected]>
Signed-off-by: Kevin Traynor <[email protected]>
  • Loading branch information
david-marchand authored and kevintraynor committed Jan 30, 2025
1 parent f0e6638 commit cde1069
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 86 deletions.
2 changes: 1 addition & 1 deletion Documentation/intro/install/general.rst
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ other than plain text, only if you have the following:
If you are going to extensively modify Open vSwitch, consider installing the
following to obtain better warnings:

- "sparse" version 0.6.2 or later
- "sparse" version 0.6.4 or later
(https://git.kernel.org/pub/scm/devel/sparse/sparse.git/).

- GNU make.
Expand Down
3 changes: 0 additions & 3 deletions include/sparse/automake.mk
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,7 @@ noinst_HEADERS += \
include/sparse/netinet/ip6.h \
include/sparse/netpacket/packet.h \
include/sparse/pthread.h \
include/sparse/rte_atomic.h \
include/sparse/rte_mbuf.h \
include/sparse/rte_memcpy.h \
include/sparse/rte_trace_point.h \
include/sparse/sys/socket.h \
include/sparse/sys/sysmacros.h \
include/sparse/sys/types.h \
Expand Down
25 changes: 0 additions & 25 deletions include/sparse/rte_atomic.h

This file was deleted.

29 changes: 0 additions & 29 deletions include/sparse/rte_mbuf.h

This file was deleted.

28 changes: 0 additions & 28 deletions include/sparse/rte_trace_point.h

This file was deleted.

0 comments on commit cde1069

Please sign in to comment.