-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update Plonky3 commit #774
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
INT-1622 Update plonky3 commit
They have made some changes with audit fixes, and also an initial version of circle stark |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Detailed Metrics
Commit: a70582d |
Detailed Metrics
Commit: a70582d |
Detailed Metrics
Commit: 609b056 |
Detailed Metrics
Commit: 609b056 |
Detailed Metrics
Commit: 609b056 |
Detailed Metrics
Commit: 609b056 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were some changes to plonky3's dft in this Plonky3/Plonky3#505 where they added a RefCell
so that you can only do a single parallel dft at a time. Previously we were using rayon to somehow multithread within multithread for rayon workstealing -- this is now removed and probably inconsequential since we should likely assume DFTs are already maximally parallelized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Diff is big because plonky3 changes F::one()
to F::ONE
const.
Other change is in the dft mentioned in my previous comment.
They added additional constraints to p3-keccak-air after audit, and also removed 100 columns that were forgotten about and never used.
Verifier program updated slightly to observe more things into transcript for security.
Also challenger implementation changed to duplex after |
Resolves INT-1622