-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ECC traits #773
feat: ECC traits #773
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think it'll make things a bit clearer if we have "halo2curves" as a feature of axvm-ecc, and that means we implement traits for halo2curves types.
Also for axvm-ecc, avoid clones when possible: cloning 32-bytes becomes quite expensive in the zkvm so we should remove interfaces that encourage cloning.
Detailed Metrics
Commit: bdb183c |
Detailed Metrics
Commit: bdb183c |
Detailed Metrics
Commit: bdb183c |
Detailed Metrics
Commit: bdb183c |
benchmarks all went up by a huge amount after this last commit; need to see what's going on... |
Detailed Metrics
Commit: bdb183c |
Detailed Metrics
Commit: bdb183c |
Detailed Metrics
Commit: bdb183c |
Detailed Metrics
Commit: bdb183c |
probably just merge main |
Detailed Metrics
Commit: 3c151df |
Detailed Metrics
Commit: f04df39 |
Detailed Metrics
Commit: f04df39 |
Detailed Metrics
Commit: f04df39 |
Detailed Metrics
Commit: f04df39 |
* Move traits to axvm-ecc * WIP: Move impls to axvm-ecc w/ feature gate * Re-export curve Fq2,Fq12; tests passing * Fix lints * Update features for CI * Update vm cargo dev dependency * Update vm parallel feature * Move axvm-ecc test-utils feature * Move axvm-ecc test-utils feature * Add test-utils for axiom-vm CI * Update axiom-vm features * Fix transpiler toolchain test * Remove hand-rolled ScalarMul * Address PR comments * Remove unused comments
* Move traits to axvm-ecc * WIP: Move impls to axvm-ecc w/ feature gate * Re-export curve Fq2,Fq12; tests passing * Fix lints * Update features for CI * Update vm cargo dev dependency * Update vm parallel feature * Move axvm-ecc test-utils feature * Move axvm-ecc test-utils feature * Add test-utils for axiom-vm CI * Update axiom-vm features * Fix transpiler toolchain test * Remove hand-rolled ScalarMul * Address PR comments * Remove unused comments
lib/ecc-execution
tolib/ecc
halo2curves-axiom
inlib/ecc
temporarily; will open a new PR to move to PSE'shalo2curves
ScalarMul
trait