-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: int256 axvm library + tests #770
Conversation
INT-2515 int256 `axvm` library
We need Then we should have |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This would require new LOAD/STORE opcodes with custom BLOCK_SIZE right? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look into MIN/MAX and util sign extend!
I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This macro is crazy!
LGTM but I do think Stephen's comments about sign extension and min/max need fixing.
Detailed Metrics
Commit: f92127f |
Detailed Metrics
Commit: f92127f |
Detailed Metrics
Commit: f92127f |
Detailed Metrics
Commit: f92127f |
@@ -241,3 +254,23 @@ impl Ord for I256 { | |||
return self.as_bigint().cmp(&other.as_bigint()); | |||
} | |||
} | |||
|
|||
impl Clone for I256 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is really cool
* feat: u256 not zkvm version * address comments * fix: biguint_to_limbs * feat: towards u256 zkvm * feat: u256 + i256 axvm libraries + tests * fix: lints * fix: removed print comments * Address Comments * fix: use panic!() * feat: make a macro for implementing an operation trait * fix: alloc * fix: alloc * feat: MIN and MAX for int256 * fefat: implement our own copy + address comments * feat: add a clone test
Resolves INT-2515
Resolves INT-2541
After a lot of debugging
U256
andI256
types pass the tests:matrix-power
andmatrix-power-signed
Probably we would want to create the
zkvm
versionclone
as wellImplemented a macro that implements an operation on a struct for you (see the code). I assume we can use this macro for
IntModN
@stephenh-axiom-xyz