-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Add internal verifier & root verifier program #763
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
9b39bc5
to
1e40680
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1e40680
to
62bd97b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skimmed and generally looks ok. @zlangley should also review.
This is part of sdk task, but we'll want to quickly get the flow into sdk and then add it to benchmarks.
I do have a question about the public values root proof and what exactly we are proving/guaranteeing.
b85d535
to
2b9576d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
INT-2458 Inner aggregation program
Must be able to aggregate leaf aggregation program as well as itself. Shared a lot of code with INT-1731 so only the new part around program commitment public values should be net-new. |
19d7f3a
to
21fb207
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This comment has been minimized.
This comment has been minimized.
b26f5a8
to
36c6c9a
Compare
Detailed Metrics
Commit: 36c6c9a |
Detailed Metrics
Commit: 36c6c9a |
Detailed Metrics
Commit: 36c6c9a |
Detailed Metrics
Commit: 36c6c9a |
* Add internal verifier & root verifier program * Add doc comments for public values * Add doc comments for RootVmVerifierPvs * Remove init_memory_commit from AppExecutionCommit * Address comments
* Add internal verifier & root verifier program * Add doc comments for public values * Add doc comments for RootVmVerifierPvs * Remove init_memory_commit from AppExecutionCommit * Address comments
Doc: https://docs.google.com/document/d/151MrQqVP_v2PQgLP-72Vy0fxzbv2k3RQ_Y3VwpqJTUQ/edit?tab=t.0
closes INT-2458
TODO: