Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] generic field expression vm chip #653

Merged
merged 6 commits into from
Oct 24, 2024
Merged

Conversation

luffykai
Copy link
Contributor

@luffykai luffykai commented Oct 23, 2024

toward INT-2392

  • replaced (simplified) ec add and double
  • modular will be next (needs flag <-> opcode conversion)

@luffykai luffykai force-pushed the lunkai/expression-chip branch from b722042 to ce562f8 Compare October 23, 2024 22:16
@luffykai luffykai marked this pull request as ready for review October 23, 2024 22:16
@luffykai luffykai force-pushed the lunkai/expression-chip branch from 383b956 to a3103df Compare October 23, 2024 22:52
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is a beautiful improvement.

I think we should avoid the typedef now since it can be confusing/misused. Either we just remove typedef and reference the structs directly, or we start making newtypes.

@luffykai luffykai merged commit 872a83b into main Oct 24, 2024
10 checks passed
@luffykai luffykai deleted the lunkai/expression-chip branch October 24, 2024 17:41
jonathanpwang pushed a commit that referenced this pull request Oct 24, 2024
* generic field expression vm chip

* add ne simplified

* double

* fix

* update

* use struct
jonathanpwang added a commit that referenced this pull request Oct 25, 2024
* Add exit code in the terminate transpiler

* chore: make terminate I-type

* compile terminate.S into ELF

* fix:remove terminate.dump

* fix: terminate

* feat: AlignedBorrow on MerkleMemoryCols (#661)

* Add CommittedProgram (#658)

* chore: runs-on for benchmark (#651)

* chore: runs-on for benchmark

* chore: fix path

* chore: clean up

* feat: Clean up core chip (#663)

* Add `is_valid` to CoreCols
* Remove DUMMY opcode
* Remove `f` and `g` operands

* [feat] generic field expression vm chip (#653)

* generic field expression vm chip

* add ne simplified

* double

* fix

* update

* use struct

* chore: fix runs_on (#665)

* chore: fix git config

* chore: add back merge to main control

* Expose is_terminate as a public value (#666)

* feat: Always increment timestamp (#667)

* fix (#668)

* Chore: transpile shamts in a more natural way (same functionality, but not a goldberg machine) (#669)

* fix: Nop needs to increment timestamp now

* fix: test

* fix: build ELF and add command

---------

Co-authored-by: Jonathan Wang <[email protected]>
Co-authored-by: Arayi <[email protected]>
Co-authored-by: Zach Langley <[email protected]>
Co-authored-by: Xinding Wei <[email protected]>
Co-authored-by: PangZhi <[email protected]>
Co-authored-by: luffykai <[email protected]>
luffykai added a commit that referenced this pull request Dec 13, 2024
* generic field expression vm chip

* add ne simplified

* double

* fix

* update

* use struct
luffykai added a commit that referenced this pull request Dec 13, 2024
* Add exit code in the terminate transpiler

* chore: make terminate I-type

* compile terminate.S into ELF

* fix:remove terminate.dump

* fix: terminate

* feat: AlignedBorrow on MerkleMemoryCols (#661)

* Add CommittedProgram (#658)

* chore: runs-on for benchmark (#651)

* chore: runs-on for benchmark

* chore: fix path

* chore: clean up

* feat: Clean up core chip (#663)

* Add `is_valid` to CoreCols
* Remove DUMMY opcode
* Remove `f` and `g` operands

* [feat] generic field expression vm chip (#653)

* generic field expression vm chip

* add ne simplified

* double

* fix

* update

* use struct

* chore: fix runs_on (#665)

* chore: fix git config

* chore: add back merge to main control

* Expose is_terminate as a public value (#666)

* feat: Always increment timestamp (#667)

* fix (#668)

* Chore: transpile shamts in a more natural way (same functionality, but not a goldberg machine) (#669)

* fix: Nop needs to increment timestamp now

* fix: test

* fix: build ELF and add command

---------

Co-authored-by: Jonathan Wang <[email protected]>
Co-authored-by: Arayi <[email protected]>
Co-authored-by: Zach Langley <[email protected]>
Co-authored-by: Xinding Wei <[email protected]>
Co-authored-by: PangZhi <[email protected]>
Co-authored-by: luffykai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants