-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] generic field expression vm chip #653
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b722042
to
ce562f8
Compare
383b956
to
a3103df
Compare
jonathanpwang
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is a beautiful improvement.
I think we should avoid the typedef now since it can be confusing/misused. Either we just remove typedef and reference the structs directly, or we start making newtypes.
jonathanpwang
approved these changes
Oct 24, 2024
jonathanpwang
pushed a commit
that referenced
this pull request
Oct 24, 2024
* generic field expression vm chip * add ne simplified * double * fix * update * use struct
jonathanpwang
added a commit
that referenced
this pull request
Oct 25, 2024
* Add exit code in the terminate transpiler * chore: make terminate I-type * compile terminate.S into ELF * fix:remove terminate.dump * fix: terminate * feat: AlignedBorrow on MerkleMemoryCols (#661) * Add CommittedProgram (#658) * chore: runs-on for benchmark (#651) * chore: runs-on for benchmark * chore: fix path * chore: clean up * feat: Clean up core chip (#663) * Add `is_valid` to CoreCols * Remove DUMMY opcode * Remove `f` and `g` operands * [feat] generic field expression vm chip (#653) * generic field expression vm chip * add ne simplified * double * fix * update * use struct * chore: fix runs_on (#665) * chore: fix git config * chore: add back merge to main control * Expose is_terminate as a public value (#666) * feat: Always increment timestamp (#667) * fix (#668) * Chore: transpile shamts in a more natural way (same functionality, but not a goldberg machine) (#669) * fix: Nop needs to increment timestamp now * fix: test * fix: build ELF and add command --------- Co-authored-by: Jonathan Wang <[email protected]> Co-authored-by: Arayi <[email protected]> Co-authored-by: Zach Langley <[email protected]> Co-authored-by: Xinding Wei <[email protected]> Co-authored-by: PangZhi <[email protected]> Co-authored-by: luffykai <[email protected]>
luffykai
added a commit
that referenced
this pull request
Dec 13, 2024
* generic field expression vm chip * add ne simplified * double * fix * update * use struct
luffykai
added a commit
that referenced
this pull request
Dec 13, 2024
* Add exit code in the terminate transpiler * chore: make terminate I-type * compile terminate.S into ELF * fix:remove terminate.dump * fix: terminate * feat: AlignedBorrow on MerkleMemoryCols (#661) * Add CommittedProgram (#658) * chore: runs-on for benchmark (#651) * chore: runs-on for benchmark * chore: fix path * chore: clean up * feat: Clean up core chip (#663) * Add `is_valid` to CoreCols * Remove DUMMY opcode * Remove `f` and `g` operands * [feat] generic field expression vm chip (#653) * generic field expression vm chip * add ne simplified * double * fix * update * use struct * chore: fix runs_on (#665) * chore: fix git config * chore: add back merge to main control * Expose is_terminate as a public value (#666) * feat: Always increment timestamp (#667) * fix (#668) * Chore: transpile shamts in a more natural way (same functionality, but not a goldberg machine) (#669) * fix: Nop needs to increment timestamp now * fix: test * fix: build ELF and add command --------- Co-authored-by: Jonathan Wang <[email protected]> Co-authored-by: Arayi <[email protected]> Co-authored-by: Zach Langley <[email protected]> Co-authored-by: Xinding Wei <[email protected]> Co-authored-by: PangZhi <[email protected]> Co-authored-by: luffykai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toward INT-2392