Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: optimize IsLessThanTupleCols #64

Merged
merged 1 commit into from
Jun 13, 2024
Merged

chore: optimize IsLessThanTupleCols #64

merged 1 commit into from
Jun 13, 2024

Conversation

bfan05
Copy link
Contributor

@bfan05 bfan05 commented Jun 12, 2024

No description provided.

@bfan05 bfan05 requested a review from jonathanpwang June 12, 2024 22:22
jonathanpwang
jonathanpwang approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, I thought you could directly use IsEqualVec subair for the constraints, but that would have duplicated a bunch of bit decompositions.

lgtm

@jonathanpwang jonathanpwang merged commit 3549d03 into main Jun 13, 2024
3 checks passed
@jonathanpwang jonathanpwang deleted the chore/optimize-is-less-than-tuple branch June 13, 2024 05:35
luffykai pushed a commit that referenced this pull request Dec 13, 2024
@bfan05
chore: optimize IsLessThanTupleCols (#64)
b40e282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bfan05 @jonathanpwang