[feat] BN254 AssertFinalExponentiationIsOne #515
Conversation
ytham
commented
Oct 9, 2024
•
ytham
commented
- assert_final_exponentiation_is_one
- final_exp_hint
ytham
force-pushed
the
feat/assert-final-exponentiation-one
branch
from
7065ed7 to
8c71566
Compare
This reverts commit 61dfdf4.
…t/assert-final-exponentiation-one
ytham
changed the title
riscv/transpiler/Cargo.toml
Outdated
| @@ -20,6 +20,6 @@ p3-uni-stark = { workspace = true } | |||
| axvm-platform = { workspace = true } | |||
| stark-vm = { workspace = true } | |||
|
|
|||
| color-eyre = "0.6.3" | |||
| color-eyre = { git = "https://github.com/eyre-rs/eyre.git" } | |||
There was a problem hiding this comment.
why is this not using the workspace version?
There was a problem hiding this comment.
unfortunately, it seems that I need to use a recent version of color-eyre in ricsv/transpiler due to workflow builds failing due to eyre-rs/eyre#175 (merged, but there hasn't been any new crate release since 2022); my builds are failing with this error: https://github.com/axiom-crypto/afs-prototype/actions/runs/11300218384/job/31432675915 which is fixed w/ that PR. it might be safer to lock it to the latest commit, which I can add
jonathanpwang
changed the title
There was a problem hiding this comment.
LGTM.
For constants fixed for all of BN254, best to make [lazy_]static variables for them.
Also let's add some links in the code comments to gnark to give them due credit.
Clarification: this does AssertFinalExponentiationIsOne for Bn254, but we still need to do BLS12-381 (which should be much more straightforward now -- just be careful about pre_loop).
…om-crypto/afs-prototype into feat/assert-final-exponentiation-one
* Add final exponentiation traits * WIP; test failing * Updated bn254 final exp * Add WIP native exponentiation as a test * debug: add debug assert to only call final exp hint when finalexp=1 * Try e(aP,bQ)e(cP,dQ) where a=5,b=10,c=-2,d=25 * Fix point negation; still failing * Rename vars * verify miller points match * It's working * Fix lints * Update cargo * Remove eyre conflict for workflow * Revert "Remove eyre conflict for workflow" This reverts commit 61dfdf4. * Use master color-eyre * Update ecc/execution/src/common/miller_loop.rs * Address PR comments --------- Co-authored-by: Jonathan Wang <[email protected]>
