refactor: rename chip trait and clarify air vs chip #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zlangley
commented
Jun 6, 2024
zlangley
commented
- Renaming Chip trait to AirBridge
- Renaming SubAirWithInteractions trait to SubAirBridge
- Factor out/rename *Chip structs to *Air for the parts that define constraints
zlangley
force-pushed
the
zach/int-1548-refactor-chip-trait-to-hasinteractions-and-clarify-air-vs
branch
from
40e9452 to
1af9705
Compare
zlangley
force-pushed
the
zach/int-1548-refactor-chip-trait-to-hasinteractions-and-clarify-air-vs
branch
from
1af9705 to
2e4b395
Compare
zlangley
changed the title
…ractions-and-clarify-air-vs
jonathanpwang
deleted the
zach/int-1548-refactor-chip-trait-to-hasinteractions-and-clarify-air-vs
branch
luffykai
pushed a commit
that referenced
this pull request
Dec 13, 2024
* Rename Chip to AirBridge * SubAirWithInteractions -> SubAirBridge * IsEqualAir * IsEqualVecAir * IsZeroAir * KeccakPermuteAir * MerkleProofAir * PageReadAir * RangeAir * RangeCheckerGateAir * XorLookupAir * XorLimbsAir * XorBitsAir --------- Co-authored-by: Jonathan Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.