chore: switch IsZeroChip to AB::Expr for re-usability
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpwang
force-pushed
the
chore/is_zero_expr
branch
from
edd089c to
bd32c93
Compare
jonathanpwang
added a commit
that referenced
this pull request
Jun 10, 2024
This reverts commit 3eeb409.
luffykai
pushed a commit
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstrate how to make a SubAir allow taking in arithmetic expressions for re-usability.
The result is ugly enough that I think it's also ok to disregard this PR and keep things as is.
An annoyance is that
AB::Exprdoes not implementCopy, onlyCloneso there are more clones necessary.