-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added page_read_chip and page_controller #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly cosmetic changes requested. Can merge after addressing.
The main other change (for another PR) is that we need a slightly different version to handle indexed pages - these are where the key are several columns that are part of the cached trace, and we don't have an auto-generate index starting from 0.
I think there will be use cases for both, but not sure how to best refactor to make things as modular as possible. This is something to keep in mind when writing the read/write chip.
In other words, the current index
column with the constraint that it auto-increments by 1, is not needed if the page itself has columns for keys. One option is to make that index column optional, and configurable in the chip constructor.
@OsamaAlkhodairy for future use, and to stabilize the Page interface, let's add the cached trace commitment of the page as a public value to the PageReadChip. However this requires being able to convert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, change some debug prints to log
* feat: added page_read_chip and page_controller * fix: rust lint * fix: rust lint * chore: small edits * chore: updating to use the engine * chore: fixing imports * wip * feat: storing commitment in page_controller and other fixes * fix: adding tracing
spec: https://docs.google.com/document/d/1ajsBRZ6O5QRD5CgqlVfnc2c-tWh3gcUdbLH0KKE-3Js/edit