feat: range checker chip using a gate #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…preprocessed column
OsamaAlkhodairy
changed the title
jonathanpwang
requested changes
May 22, 2024
jonathanpwang
approved these changes
May 23, 2024
|
|
||
| let mut challenger = config::poseidon2::Challenger::new(perm.clone()); | ||
|
|
||
| let result = catch_unwind(AssertUnwindSafe(|| { |
There was a problem hiding this comment.
was this issue here that the debug builder had an assert failing? you can turn off debug assert like this: https://github.com/axiom-crypto/afs-prototype/blob/fed9b82817325ef174c6a4a40056af7d89bef72d/stark-backend/tests/partitioned_sum_air/mod.rs#L88 to prevent the panic
There was a problem hiding this comment.
No, here I expect an assert to fail because the AIR constraints aren't met so I wanted to catch it (and then assert that there was an error)
There was a problem hiding this comment.
I meant that I think the assert might only be coming from the debug builder, which can be turned off if you wanted
luffykai
pushed a commit
that referenced
this pull request
Dec 13, 2024
* feat: added another range checker chip that uses a gate instead of a preprocessed column * fix: fixed first row constraints and added negative test * chore: using run_simple_test function for all tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.