Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove Vec from MemoryRecord interface #1298

Merged
merged 2 commits into from
Jan 26, 2025

Conversation

zlangley
Copy link
Contributor

This allows us to change out the implementation (e.g., SmallVec) without affecting the interface

@zlangley zlangley force-pushed the memory-record-interface branch from eab49ab to 3f17d03 Compare January 26, 2025 19:48
This allows us to change out the implementation (e.g., SmallVec) without
affecting the interface
@zlangley zlangley force-pushed the memory-record-interface branch from 3f17d03 to 50bd229 Compare January 26, 2025 19:53
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@jonathanpwang
Copy link
Contributor

Hm keccak test is failing

Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-28 [-1.3%]) 2,200 513,772 19,376,241 - - -
fibonacci_program (+6 [+0.1%]) 5,285 1,500,095 51,485,080 - - -
regex_program (-156 [-1.0%]) 15,103 (+2225737 [+116.3%]) 4,139,840 (-1623938 [-1.0%]) 163,831,435 - - -
ecrecover_program (+48 [+1.9%]) 2,594 284,567 15,055,723 - - -

Commit: 3f76e13

Benchmark Workflow

@jonathanpwang jonathanpwang merged commit cb44337 into main Jan 26, 2025
22 checks passed
@jonathanpwang jonathanpwang deleted the memory-record-interface branch January 26, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants