-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Implement sys_rand
#1294
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move integration test to rv32im/test
.
Currently the phantom instruction is wrong: it needs to read len from memory address space 1.
Update ISA doc: it's easier to make a PR into #1291
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Commit: a5c71aa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This resolves INT-2955.
sys_rand
now:The integration test is a simple one and just shows that the hashmap works somehow (it didn't use to because of "
sys_rand
unimplemented", but maybe we could also check the statistical randomness of our calls somehow.