-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] expr builder eval inconsistency #1289
Conversation
This comment has been minimized.
This comment has been minimized.
#[allow(unused)] | ||
fn debug_print(&self, msg: &str) { | ||
if self.debug { | ||
println!("{}", msg); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is this different than when you just use dbg!
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when adding print to mod-builder, it applies to all chips using it. But usually when debugging i only care about one chip. So the way I use this is to call set_debug only at the specific chip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but can you move the test to pairing tests crate instead
This comment has been minimized.
This comment has been minimized.
Commit: d507515 |
Issue: the way we do
evaluate_overflow_isize
andevaluate_overflow_expr
were inconsistent forSelect
Since we had flag available for isize we directly using it to choose left or right, but that's not viable in expr. But this inconsistency MIGHT result in different
max_overflow_bit
in some condition (=> ended up in range checker error), which we only discovered with BLS curve double setup...