Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: config inheritance in the VmConfig derive macro #1274

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

stephenh-axiom-xyz
Copy link
Contributor

@stephenh-axiom-xyz stephenh-axiom-xyz commented Jan 24, 2025

Implements the following:

  • VmConfig macro implements config inheritance (via the #[config] attribute in place of #[system])
  • Rv32ImConfig inherits base and io from Rv32IConfig
  • impl VmExtension for the option of an arbitrary VmExtension

This comment has been minimized.

Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+14 [+0.6%]) 2,344 513,457 19,359,162 - - -
fibonacci_program (+18 [+0.3%]) 6,115 1,500,092 51,484,605 - - -
regex_program (+714 [+4.0%]) 18,550 4,139,836 163,833,427 - - -
ecrecover_program (-10 [-0.4%]) 2,599 284,561 15,054,935 - - -

Commit: e7d9558

Benchmark Workflow

@jonathanpwang
Copy link
Contributor

@Golovanov399 if you get a chance can you review

Copy link
Contributor

@Golovanov399 Golovanov399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good
Although I didn't really understand the point of impl VmExtension for Option

@stephenh-axiom-xyz stephenh-axiom-xyz merged commit 15ce999 into main Jan 24, 2025
22 checks passed
@stephenh-axiom-xyz stephenh-axiom-xyz deleted the feat/vm-config-inheritance branch January 24, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants