Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add contributor documentation for the mod-builder framework #1273

Merged
merged 2 commits into from
Jan 26, 2025
Merged

[docs] Add contributor documentation for the mod-builder framework #1273

merged 2 commits into from
Jan 26, 2025

Conversation

Avaneesh-axiom
Copy link
Contributor

@Avaneesh-axiom Avaneesh-axiom commented Jan 23, 2025 •
edited
Loading

The first two commits are from #1269 and they will be merged into main soon.

The important commit for this issue is the third one.

Closes INT-3089

@Avaneesh-axiom Avaneesh-axiom force-pushed the feat/add-mod-builder-docs branch from 7a74190 to a48ffa9 Compare January 23, 2025 23:11
@Avaneesh-axiom Avaneesh-axiom marked this pull request as ready for review January 23, 2025 23:22
@jonathanpwang jonathanpwang changed the title [feat] Add contributor documentation for the mod-builder framework [docs] Add contributor documentation for the mod-builder framework Jan 24, 2025
@jonathanpwang jonathanpwang force-pushed the feat/add-mod-builder-docs branch from a48ffa9 to 3449770 Compare January 26, 2025 06:23
jonathanpwang
jonathanpwang approved these changes Jan 26, 2025
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanpwang jonathanpwang merged commit b074994 into main Jan 26, 2025
11 checks passed
@jonathanpwang jonathanpwang deleted the feat/add-mod-builder-docs branch January 26, 2025 06:28
@github-actions GitHub Actions
Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+18 [+0.8%]) 2,190 513,915 19,377,671 - - -
fibonacci_program (+17 [+0.3%]) 5,178 1,500,137 51,487,838 - - -
regex_program (-58 [-0.4%]) 14,533 4,190,904 165,010,909 - - -
ecrecover_program (-49 [-1.9%]) 2,537 285,401 15,075,033 - - -

Commit: 0efc5a9

Benchmark Workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Avaneesh-axiom @jonathanpwang