Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[feat] support execute until segment" #1268

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Revert "[feat] support execute until segment" #1268

merged 1 commit into from
Jan 23, 2025

Conversation

luffykai
Copy link
Contributor

Reverts #1251
broke reth benchmark

@linear Linear
Copy link

linear bot commented Jan 23, 2025

Issue reopened: INT-3004 support execute_until_segment

@github-actions GitHub Actions
Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+45 [+1.9%]) 2,386 513,369 19,358,282 - - -
fibonacci_program (+62 [+1.0%]) 6,143 1,500,137 51,487,838 - - -
regex_program (+280 [+1.5%]) 18,668 4,190,904 165,010,909 - - -
ecrecover_program (-21 [-0.8%]) 2,567 285,401 15,075,033 - - -

Commit: 85b646c

Benchmark Workflow

@yi-sun yi-sun merged commit 95208f4 into main Jan 23, 2025
22 checks passed
@yi-sun yi-sun deleted the revert-1251-lunkai/exec-1seg branch January 23, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yi-sun yi-sun yi-sun approved these changes

@jonathanpwang jonathanpwang Awaiting requested review from jonathanpwang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luffykai @yi-sun