fix: EcDoubleChip dummy row #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit: 2bd377c |
luffykai
reviewed
Jan 20, 2025
| let mut row = vec![F::ZERO; adapter_width + core_width]; | ||
| let core_row = &mut row[adapter_width..]; | ||
| // We **do not** want this trace row to update the range checker | ||
| // so we must create a temporary range checker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the dummy row to have
is_valid=0, is_double=0. Previously we did this by duplicating the first row. However when the same chip is used across continuation segments, the first row might not be setup. So now we explicitly generate the dummy row to have the above properties.