Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

range check: add debug_assert #1228

Closed
wants to merge 1 commit into from
Closed

Conversation

lispc
Copy link
Contributor

@lispc lispc commented Jan 17, 2025

is this a good idea?

is this a good idea?

This comment has been minimized.

@jonathanpwang
Copy link
Contributor

I think we have negative tests that you'd need to deal with somehow. maybe you can use some static variable when #[cfg(debug_assertions)]?

@lispc
Copy link
Contributor Author

lispc commented Jan 17, 2025

ok negative tests..
let me think

@lispc lispc closed this Jan 17, 2025
@lispc lispc reopened this Jan 17, 2025
Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair 3,501 711,284 25,510,945 - - -
fibonacci_program (+18 [+0.3%]) 6,156 1,500,137 51,505,102 - - -
regex_program (-61 [-0.3%]) 18,861 4,190,904 165,028,173 - - -
ecrecover_program (-10 [-0.4%]) 2,599 285,401 15,092,297 - - -

Commit: d31bd5e

Benchmark Workflow

@lispc
Copy link
Contributor Author

lispc commented Jan 23, 2025

i feel in future we may design a systematic way for these checks. Either env var, or another feature flag, or a boolean const generic. I'd like to close it now.

@lispc lispc closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants