Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] sdk refactor: separate leaf running + scheduling #1221

Merged
merged 7 commits into from
Jan 21, 2025
Merged

[chore] sdk refactor: separate leaf running + scheduling #1221

merged 7 commits into from
Jan 21, 2025

Conversation

luffykai
Copy link
Contributor

@luffykai luffykai commented Jan 16, 2025 •
edited
Loading

ref INT-3046
ref INT-3001

the binary is just skeleton, @Jocn2020 will take over

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@luffykai luffykai marked this pull request as ready for review January 17, 2025 16:21
@luffykai luffykai changed the title [chore] sdk refactor: WIP [chore] sdk refactor: separate leaf running + scheduling Jan 17, 2025
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@luffykai luffykai requested a review from nyunyunyunyu January 17, 2025 16:30
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
luffykai
luffykai commented Jan 20, 2025
View reviewed changes
crates/sdk/src/bin/app_prover.rs
@@ -0,0 +1,3 @@
fn main() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jocn2020 will start building this one

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
jonathanpwang
jonathanpwang approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except use benchmark arg for leaf num children if it exists

@github-actions GitHub Actions
Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+1171 [+50.6%]) 3,484 (+199670 [+39.0%]) 711,538 (+6203136 [+32.1%]) 25,513,485 - - -
fibonacci_program (-108 [-1.8%]) 6,004 1,500,137 51,505,102 - - -
regex_program (-34 [-0.2%]) 18,812 4,190,904 165,028,173 - - -
ecrecover_program (+35 [+1.4%]) 2,622 285,401 15,092,297 - - -

Commit: d0c11af

Benchmark Workflow

@luffykai luffykai merged commit 95a6aa7 into main Jan 21, 2025
10 checks passed
@luffykai luffykai deleted the lunkai/sdk-ref1 branch January 21, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

@nyunyunyunyu nyunyunyunyu Awaiting requested review from nyunyunyunyu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luffykai @jonathanpwang