-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update SDK example for app and EVM proofs #1163
Conversation
ytham
commented
Jan 3, 2025
- Splits Book SDK section into two subsections for app and EVM proofs.
- Separates sdk example sdk.rs into two files: sdk_app.rs, sdk_evm.rs
- NOTE: there is a fair amount of reused code; this was done intentionally for the sake of making the examples easier to read in isolation, as well as to keep the imports in the book a bit cleaner. I can create some common functions instead if it's preferred.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer if the sdk md stays in one file, we can make the EVM Proof part a larger heading and explain that the generate_app_proof
does not need to be called.
The sdk_app.rs, sdk_evm.rs
split makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM