Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(recursion): remove extraneous functions from TwoAdicPcs verify #1152

Merged
merged 3 commits into from
Jan 1, 2025

Conversation

jonathanpwang
Copy link
Contributor

@jonathanpwang jonathanpwang commented Jan 1, 2025

To match refactors in plonky3. This has benefit that it removes extraneous array allocations and load/stores.

Cherry-picked from #1139 to separate the changes.

@jonathanpwang jonathanpwang added run-benchmark triggers benchmark workflows on the pr run-benchmark-e2e labels Jan 1, 2025
Copy link

github-actions bot commented Jan 1, 2025

Benchmarks

group app_log_blowup app_total_cells_used app_total_cycles app_total_proof_time_ms leaf_log_blowup leaf_total_cells_used leaf_total_cycles leaf_total_proof_time_ms max_segment_length instance alloc
ecrecover_program
2
15,230,037
290,016
(+7.0 [+0.3%])
2,391.0
2
(-78,747 [-0.0%])
445,651,278
(+1,711 [+0.0%])
9,780,100
(-112.0 [-0.3%])
34,901.0
1048476 64cpu-linux-arm64 mimalloc
fibonacci_program
2
51,505,102
1,500,137
(-3.0 [-0.1%])
5,449.0
2
(-105,105 [-0.1%])
128,861,566
(-685 [-0.0%])
3,172,689
(-17.0 [-0.1%])
13,841.0
1048476 64cpu-linux-arm64 mimalloc
regex_program
2
165,028,173
4,190,904
(+40.0 [+0.3%])
15,876.0
2
(-72,037 [-0.0%])
291,323,025
(+2,445 [+0.0%])
6,526,186
(+339.0 [+1.3%])
26,780.0
1048476 64cpu-linux-arm64 mimalloc
verify_fibair
2
(-109,532 [-1.3%])
8,011,682
(-667 [-0.3%])
194,687
(-29.0 [-2.0%])
1,431.0
-
-
-
-
1048476 64cpu-linux-arm64 mimalloc

E2E Benchmarks

group app_log_blowup app_total_cells_used app_total_cycles app_total_proof_time_ms leaf_log_blowup leaf_total_cells_used leaf_total_cycles leaf_total_proof_time_ms root_log_blowup root_total_cells_used root_total_cycles root_total_proof_time_ms internal_log_blowup internal_total_cells_used internal_total_cycles internal_total_proof_time_ms max_segment_length instance alloc
fib_e2e
2
410,820,430
12,000,137
35,797.0
2
131,613,463
3,363,053
74,873.0
2
770,555,721
19,058,336
81,913.0
2
1,665,477,802
42,757,172
178,597.0
1048476 64cpu-linux-arm64 mimalloc

Commit: 27574da

Benchmark Workflow

@jonathanpwang jonathanpwang merged commit 183cb6a into main Jan 1, 2025
13 checks passed
@jonathanpwang jonathanpwang deleted the perf/streamline-pcs-verify branch January 1, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-benchmark triggers benchmark workflows on the pr run-benchmark-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant