chore: removing auxiliary folders from inner_join/ #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpwang
approved these changes
Jul 6, 2024
TlatoaniHJ
pushed a commit
that referenced
this pull request
Jul 8, 2024
TlatoaniHJ
added a commit
that referenced
this pull request
Jul 9, 2024
* feat: FieldExtensionArithmeticChip with add, sub, mul, inv operations * chore: address comments and rename operations * chore: address comments * chore: fix lint * feat: plonky3 consistency test * chore: address comments * chore: follow new interaction pattern * wip * wip * wip * wip * chore: change MAX_ACCESSES_PER_CYCLE * feat: field extension arithmetic chip following new trace conventions * chore: fix cpu tests * removing auxiliary folders (#114) * chore: rename `poseidon2` crate to `poseidon2-air` (#117) * Add timestamp to VM * Fix import in CPU tests * Remove unused import * Make test memory accesses more readable * Use start_timestamp as name * Rustfmt --------- Co-authored-by: bfan <[email protected]> Co-authored-by: Osama Alkhodairy <[email protected]> Co-authored-by: Jonathan Wang <[email protected]>
luffykai
pushed a commit
that referenced
this pull request
Dec 13, 2024
luffykai
pushed a commit
that referenced
this pull request
Dec 13, 2024
* feat: FieldExtensionArithmeticChip with add, sub, mul, inv operations * chore: address comments and rename operations * chore: address comments * chore: fix lint * feat: plonky3 consistency test * chore: address comments * chore: follow new interaction pattern * wip * wip * wip * wip * chore: change MAX_ACCESSES_PER_CYCLE * feat: field extension arithmetic chip following new trace conventions * chore: fix cpu tests * removing auxiliary folders (#114) * chore: rename `poseidon2` crate to `poseidon2-air` (#117) * Add timestamp to VM * Fix import in CPU tests * Remove unused import * Make test memory accesses more readable * Use start_timestamp as name * Rustfmt --------- Co-authored-by: bfan <[email protected]> Co-authored-by: Osama Alkhodairy <[email protected]> Co-authored-by: Jonathan Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the GroupBy PR had some extra folders (
my_initial_tableandmy_final_table) from my inner_join branch that were removed later before merging inner_join. Just removed them