-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: lints to guest programs #1131
Conversation
By |
@jonathanpwang so linting |
I think we can keep
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after adding the other **/programs
directories
Personally imo instead of allow clippy for functions like mult, have guest util crate and ppl can import it sounds nicer - also if then as its abstracted under other crate can just use iterator for have perf - but mb not scope of this PR : ) |
Some CI tests are failing; you may need to merge/rebase main, and also an issue with |
Can you merge |
umm issue was prob not from main merge ( also did one) it from |
I see, I think because pairing test require feature |
Yea I agree this is best practice. In this case the functions in those examples were purely one-time tests, so we don't really expect to re-use and they're not perf critical. |
target to resolve #1125
q. cannot find
**/test/programs
so had withexamples/*