-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: modularize toolchain tests #1102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update the layout.md doc too
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall refactor and modularization looks good. I had some inline comments but also we should:
- Add the
cargo nextest
to each of the respective github workflows (e.g., ecc.yml), right now the tests won't actually be run. - Can we add for each of the examples linked from the book, the correct
openvm.toml
to the test programs dir? - After (2), test locally that the cli works, then let's add tests to cli.yml where we run the cli from the test guest program dir exactly as one should do it from the book. This way CI will check that the book is up to date without us having to manually check.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
.github/workflows/cli.yml
Outdated
- run-id=${{ github.run_id }} | ||
- family=m7 | ||
- runs-on=${{ github.run_id }} | ||
- runner=32cpu-linux-arm64 | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: dtolnay/rust-toolchain@stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except some minor CI cleanup
Benchmarks
Commit: 00ba22f |
Resolves INT-2740
Moved the tests in
./crates/toolchain/tests
into respectivetest
crates inside the correspondingextensions