Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Use u32 for address_space and address internally #1101

Merged
merged 3 commits into from
Dec 17, 2024
Merged

perf: Use u32 for address_space and address internally #1101

merged 3 commits into from
Dec 17, 2024

Conversation

zlangley
Copy link
Contributor

No description provided.

@zlangley zlangley added the run-benchmark triggers benchmark workflows on the pr label Dec 16, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@zlangley zlangley changed the title perf: Use usize for address_space internally everywhere perf: Use u32 for address_space internally everywhere Dec 17, 2024
@zlangley zlangley changed the title perf: Use u32 for address_space internally everywhere perf: Use u32 for address_space and address internally Dec 17, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

Benchmarks

group app_log_blowup app_total_cells_used app_total_cycles app_total_proof_time_ms leaf_log_blowup leaf_total_cells_used leaf_total_cycles leaf_total_proof_time_ms max_segment_length instance alloc
ecrecover_program
2
10,251,804
195,066
(+100.0 [+5.0%])
2,119.0
-
-
-
-
1048476 64cpu-linux-arm64 mimalloc
fibonacci_program
2
51,615,800
3,000,274
(+8.0 [+0.1%])
5,538.0
2
(-5,590 [-0.0%])
144,213,933
(-838 [-0.0%])
7,036,736
(+167.0 [+1.2%])
14,522.0
1048476 64cpu-linux-arm64 mimalloc
regex_program
2
238,890,449
8,381,808
(-51.0 [-0.3%])
17,286.0
2
(-14,680 [-0.0%])
315,463,827
(-3,034 [-0.0%])
14,646,880
(-479.0 [-1.6%])
28,977.0
1048476 64cpu-linux-arm64 mimalloc
verify_fibair
2
(-980 [-0.0%])
48,126,547
(-182 [-0.0%])
397,142
(-34.0 [-1.1%])
3,147.0
-
-
-
-
1048476 64cpu-linux-arm64 mimalloc

Commit: 3a825d3

Benchmark Workflow

jonathanpwang
jonathanpwang approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanpwang jonathanpwang merged commit 3be4942 into main Dec 17, 2024
16 checks passed
@jonathanpwang jonathanpwang deleted the equipart branch December 17, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

Assignees
No one assigned
Labels
run-benchmark triggers benchmark workflows on the pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zlangley @jonathanpwang