Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathanpwang authored Dec 31, 2024
1 parent 6e0bf91 commit 967b8a2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions crates/circuits/sha256-air/src/trace.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ impl Sha256Air {
new_hash
}

/// This function takes the input_massage (should be already padded), the previous hash,
/// This function takes a 512-bit chunk of the input message (padding not handled), the previous hash,
/// a flag indicating if it's the last block, the global block index, the local block index,
/// and the buffer values that will be put in rows 0..4.
/// Will populate the given `trace` with the trace of the block, where the width of the trace is `trace_width`
/// and the starting column for the `Sha256Air` is `trace_start_col`.
/// Note that, some values cannot be correctly generated at this time, refer to [`generate_missing_cells`] for details
/// **Note**: this function only generates some of the required trace. Another pass is required, refer to [`generate_missing_cells`] for details.
#[allow(clippy::too_many_arguments)]
pub fn generate_block_trace<F: PrimeField32>(
&self,
Expand Down

0 comments on commit 967b8a2

Please sign in to comment.