-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring ConvModule
by removing norm_cfg
#3816
Refactoring ConvModule
by removing norm_cfg
#3816
Conversation
aed5b08
to
b77cc8c
Compare
b77cc8c
to
49da71e
Compare
@sooahleex @harimkang I saw the performance drop for deit_tiny and efficientnet_v2 on hlabel classification as below.
If you already know this, feel free to ignore it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your lots of work :) LGTM. I left some minor comments. Please check it's worth to apply later.
* Reflect comments in openvinotoolkit#3816 * Enable nn.Module standalone * Update
* Reflect comments in openvinotoolkit#3816 * Enable nn.Module standalone * Update
Summary
This PR includes:
Update
build_norm_layer
This function can handle various format of
normalization
:tuple[norm_name, norm_layer]
build_norm_layer
beforetuple[norm_name, nn.Module]
nn.Module
("", nn.Module)
nn.BatchNorm2d
type
is only given(norm_name, nn.Module)
num_features
partial(nn.BatchNorm2d, eps=1)
partial
for norm layer is given(norm_name, nn.Module)
num_features
partial(build_norm_layer(nn.BatchNorm2d, requires_grad=True))
partial
ofbuild_norm_layer
for arguments ofbuild_norm_layer
(norm_name, nn.Module)
num_features
Replace
norm_cfg
withnormalization
Restore
build_activation_layer
Update
ConvModule
to use pre-instantiated normalization module and activation moduleUpdate
activation
docstringHow to test
Checklist
License
Feel free to contact the maintainers if that's a concern.