Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keypoint detection task with RTMPose #3781

Merged
merged 15 commits into from
Aug 7, 2024

Conversation

wonjuleee
Copy link
Contributor

@wonjuleee wonjuleee commented Aug 1, 2024

Summary

  • Add keypoint detection task
  • Add RTMPose-tiny for keypoint detection task
  • Performance metric: PCK accuracy for pose estimation
RTMPose-tiny pck_acc epoch
coco-small 0.38 59
coco-medium 0.46 32
coco-large 0.77 22

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@sovrasov
Copy link
Contributor

sovrasov commented Aug 2, 2024

@wonjuleee does this PR target 2.2 milestone?

Copy link
Collaborator

@kprokofi kprokofi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work and bringing new task to OTX

src/otx/core/data/entity/keypoint_detection.py Outdated Show resolved Hide resolved
src/otx/core/data/entity/keypoint_detection.py Outdated Show resolved Hide resolved
src/otx/core/data/entity/keypoint_detection.py Outdated Show resolved Hide resolved
src/otx/algo/keypoint_detection/rtmpose.py Outdated Show resolved Hide resolved
src/otx/core/metrics/pck.py Outdated Show resolved Hide resolved
src/otx/recipe/keypoint_detection/rtmpose_tiny.yaml Outdated Show resolved Hide resolved
src/otx/algo/keypoint_detection/heads/rtmcc_head.py Outdated Show resolved Hide resolved
@kprokofi kprokofi added this to the 2.2.0 milestone Aug 4, 2024
Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see that otx supports new task :) I left some comments. Please take a look.
And it's a new task, so I think it's better to update integration, e2e test and perf test to check this task. Could you update it?

src/otx/algo/keypoint_detection/utils/keypoint_eval.py Outdated Show resolved Hide resolved
src/otx/algo/keypoint_detection/utils/keypoint_eval.py Outdated Show resolved Hide resolved
src/otx/core/data/dataset/keypoint_detection.py Outdated Show resolved Hide resolved
src/otx/core/data/dataset/keypoint_detection.py Outdated Show resolved Hide resolved
src/otx/core/data/dataset/keypoint_detection.py Outdated Show resolved Hide resolved
@wonjuleee
Copy link
Contributor Author

@wonjuleee does this PR target 2.2 milestone?

correct.

Copy link
Contributor

@sungchul2 sungchul2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your hard work!
I left some comments and I'd like to suggest to update license and docstring.
And as @kprokofi said and you already know, we are WIP on refactoring and this task also would be better to be aligned with this.

src/otx/algo/keypoint_detection/heads/rtmcc_head.py Outdated Show resolved Hide resolved
src/otx/algo/keypoint_detection/heads/rtmcc_head.py Outdated Show resolved Hide resolved
src/otx/algo/keypoint_detection/losses/kl_discret_loss.py Outdated Show resolved Hide resolved
src/otx/core/data/transform_libs/torchvision.py Outdated Show resolved Hide resolved
src/otx/core/data/transform_libs/torchvision.py Outdated Show resolved Hide resolved
src/otx/core/metrics/pck.py Outdated Show resolved Hide resolved
src/otx/core/model/keypoint_detection.py Outdated Show resolved Hide resolved
src/otx/recipe/keypoint_detection/rtmpose_tiny.yaml Outdated Show resolved Hide resolved
tests/unit/algo/keypoint_detection/__init__.py Outdated Show resolved Hide resolved
tests/unit/algo/keypoint_detection/__init__.py Outdated Show resolved Hide resolved
tests/unit/algo/keypoint_detection/conftest.py Outdated Show resolved Hide resolved
src/otx/core/data/dataset/keypoint_detection.py Outdated Show resolved Hide resolved
src/otx/algo/keypoint_detection/heads/rtmcc_head.py Outdated Show resolved Hide resolved
src/otx/algo/keypoint_detection/rtmpose.py Outdated Show resolved Hide resolved
src/otx/algo/keypoint_detection/rtmpose.py Show resolved Hide resolved
@sungchul2
Copy link
Contributor

@wonjuleee Could you update CHANGELOG as well?

@sybyun
Copy link

sybyun commented Aug 7, 2024

It looks good. Hi reviewers, could you please approve this PR if you don't have any serious concern or clear suggestions? Because, this is Geti's requirement and planned to be implemented at this OTX version. Thanks.

@github-actions github-actions bot added the DOC Improvements or additions to documentation label Aug 7, 2024
@wonjuleee wonjuleee added this pull request to the merge queue Aug 7, 2024
Merged via the queue into openvinotoolkit:develop with commit 63842a9 Aug 7, 2024
17 of 18 checks passed
@wonjuleee wonjuleee deleted the add_kd_task branch August 7, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants