-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keypoint detection task with RTMPose #3781
Conversation
@wonjuleee does this PR target 2.2 milestone? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work and bringing new task to OTX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see that otx supports new task :) I left some comments. Please take a look.
And it's a new task, so I think it's better to update integration, e2e test and perf test to check this task. Could you update it?
correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your hard work!
I left some comments and I'd like to suggest to update license and docstring.
And as @kprokofi said and you already know, we are WIP on refactoring and this task also would be better to be aligned with this.
@wonjuleee Could you update CHANGELOG as well? |
It looks good. Hi reviewers, could you please approve this PR if you don't have any serious concern or clear suggestions? Because, this is Geti's requirement and planned to be implemented at this OTX version. Thanks. |
63842a9
Summary
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.