Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mm compatible modules #3780

Merged
merged 15 commits into from
Aug 2, 2024

Conversation

sungchul2
Copy link
Contributor

@sungchul2 sungchul2 commented Aug 1, 2024

Summary

This PR includes:

  • Remove mm compatible modules
    • otx/core (model, data, exporter, utils)
    • otx/recipe
  • Update docstrings and tests

**TODO : documentation should be updated such as https://github.com/openvinotoolkit/training_extensions/blob/develop/docs/source/guide/explanation/product_design.rst

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@sungchul2 sungchul2 force-pushed the remove-mm-dependencies branch from 0745607 to f02593f Compare August 1, 2024 02:22
@github-actions github-actions bot added the TEST Any changes in tests label Aug 1, 2024
@sungchul2 sungchul2 changed the title Remove mm dependencies Remove mm compatible modules Aug 1, 2024
@sungchul2
Copy link
Contributor Author

For reviewers, please let me know if something that shouldn't have been removed or updated was removed or updated, or vice versa.

@github-actions github-actions bot added the DOC Improvements or additions to documentation label Aug 1, 2024
@sungchul2 sungchul2 enabled auto-merge August 1, 2024 08:08
src/otx/core/utils/config.py Outdated Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
harimkang
harimkang previously approved these changes Aug 1, 2024
@sungchul2 sungchul2 requested review from eunwoosh and harimkang August 2, 2024 02:16
@sungchul2 sungchul2 added this pull request to the merge queue Aug 2, 2024
Merged via the queue into openvinotoolkit:develop with commit 6b916e3 Aug 2, 2024
18 checks passed
@sungchul2 sungchul2 deleted the remove-mm-dependencies branch August 2, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants