Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dinov2 models (small, base, large, giant) from VisionTransformer backbone #3744

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

wonjuleee
Copy link
Contributor

@wonjuleee wonjuleee commented Jul 16, 2024

Summary

test/acc torch.hub timm
medium 0.839562 0.827991
large 0.909567 0.8922

With the TIMM implementation, we can enable deterministic and provide more functionalities (LoRA, ToMe, etc.)

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

Copy link
Collaborator

@kprokofi kprokofi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we now remove dino_v2.DINOv2RegisterClassifier? Could you update also semantic segmentation models? Or do you plan to enable it in different PR?
Also, could you please provide experiments result and comparison with existing DINOV2?

@wonjuleee
Copy link
Contributor Author

Can we now remove dino_v2.DINOv2RegisterClassifier? Could you update also semantic segmentation models? Or do you plan to enable it in different PR? Also, could you please provide experiments result and comparison with existing DINOV2?

Thank you for the good question. I updated the PR summary with experiment results.
For the deletion of dinov2.py and support segmentation dinov2, I will come with next PR :)

@wonjuleee wonjuleee added this pull request to the merge queue Jul 19, 2024
Merged via the queue into openvinotoolkit:develop with commit 920d128 Jul 19, 2024
18 checks passed
@wonjuleee wonjuleee deleted the support_dinov2 branch July 19, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants